Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 7 #733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for PHP 7 #733

wants to merge 1 commit into from

Conversation

janbarasek
Copy link

Solve #732

  • Added support for PHP 7
  • Used all new PHP 7 features
  • Strict types
  • declare(strict_types=1);
  • Input and return data types in methods
  • Whole code refactoring and fix better readable
  • Refactoring to tab and PSR-4 convention
  • Add public method visibility

This pull request and change is maximally back compatible, but I renamed all variable names and keep different property name convention.

Please let me know which changes are acceptable to you, because I think this package should keep progress.

@GrahamCampbell
Copy link
Contributor

How much slower is this code than the original (on the same PHP version)?

@janbarasek
Copy link
Author

@GrahamCampbell Sorry for late answer, but I must make some performance testing.

Speed is same +/- 5 %, my suggestion does not change speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants