Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New planet class #16

Merged
merged 19 commits into from
Oct 8, 2023
Merged

New planet class #16

merged 19 commits into from
Oct 8, 2023

Conversation

bluescarni
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #16 (7edb354) into main (2877c85) will decrease coverage by 2.74%.
The diff coverage is 83.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   97.61%   94.87%   -2.74%     
==========================================
  Files          20       19       -1     
  Lines        1131     1230      +99     
==========================================
+ Hits         1104     1167      +63     
- Misses         27       63      +36     
Files Coverage Δ
include/kep3/core_astro/convert_anomalies.hpp 94.11% <ø> (ø)
include/kep3/planet.hpp 100.00% <100.00%> (ø)
include/kep3/planets/jpl_lp.hpp 100.00% <ø> (ø)
include/kep3/planets/keplerian.hpp 100.00% <100.00%> (ø)
src/planet.cpp 100.00% <100.00%> (ø)
src/planets/jpl_lp.cpp 98.42% <ø> (ø)
src/planets/keplerian.cpp 98.01% <ø> (ø)
include/kep3/detail/tanuki.hpp 80.11% <80.11%> (ø)

@bluescarni bluescarni changed the title (WIP) New planet class New planet class Oct 7, 2023
@bluescarni
Copy link
Member Author

bluescarni commented Oct 7, 2023

@darioizzo as far as I am concerned this is good to go.

The Python bindings tests pass on my machine, however on the CI there seems to be a failure related to some dependency conflict in the environment file. Not sure if this is yet another spurious conda failure, but I do not think it is related to the code.

Note that the new planet class requires on Windows MSVC 2022 (which is the version anyway in use by conda currently), so I have changed the CI setup accordingly.

@darioizzo
Copy link
Member

Fantastic, thanks! Merging this now as to start adopting early on the new backbone for planet.

@darioizzo darioizzo merged commit aa18222 into esa:main Oct 8, 2023
5 checks passed
@bluescarni bluescarni deleted the pr/planet_reloaded branch October 9, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants