-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New planet class #16
New planet class #16
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 97.61% 94.87% -2.74%
==========================================
Files 20 19 -1
Lines 1131 1230 +99
==========================================
+ Hits 1104 1167 +63
- Misses 27 63 +36
|
@darioizzo as far as I am concerned this is good to go. The Python bindings tests pass on my machine, however on the CI there seems to be a failure related to some dependency conflict in the environment file. Not sure if this is yet another spurious conda failure, but I do not think it is related to the code. Note that the new planet class requires on Windows MSVC 2022 (which is the version anyway in use by conda currently), so I have changed the CI setup accordingly. |
Fantastic, thanks! Merging this now as to start adopting early on the new backbone for planet. |
No description provided.