-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Workaround clang17+ / lto bug #585
Conversation
76ca64a
to
1ce48f2
Compare
@jschueller thanks for the fast PR! As far as I understand it, for the LLVM bug to trigger, link-time optimisation must be enabled - at least judging from this bugreport: I was thus wondering if it would make sense to just disable LTO if clang>=17 is detected, rather than injecting the EDIT: I am talking about the |
I propose to keep the new flag, but only use it when IPO is enabled |
d9d745a
to
2cdd13c
Compare
will close #579 |
@jschueller sorry for getting back to this only now... As far as I understand from #586, switching off IPO actually did not prevent the bug from manifesting right? If that is the case and it is ok with you, I would slightly edit this PR to enable |
oh, right, I did not take that into account |
@jschueller thank you! |
No description provided.