Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added runner actor and handle #43

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Added runner actor and handle #43

merged 3 commits into from
Jun 14, 2024

Conversation

lemosep
Copy link
Member

@lemosep lemosep commented Jun 14, 2024

No description provided.

lemosep added 3 commits June 14, 2024 09:30
A
A

e
m
remove

A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B

B

B

B

B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B

C

B
B
B
B
B
B

B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
B
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
A
C
C

A
A
A
A
A
A
A
A
A
A
A
A
A
B
B
B
B
B
B
B
B
B
B
B
B
C
C
Co-authored-by: Luiz Felipe Gonçalves <[email protected]>
@lemosep lemosep requested a review from YuriRDev June 14, 2024 15:44
Copy link
Contributor

@YuriRDev YuriRDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I miss a few documentations around the structs and functions. It'll be nice if you take 10 minutes to write it.

proto/src/worker/runner.rs Outdated Show resolved Hide resolved
worker/src/runner/mod.rs Show resolved Hide resolved
worker/src/main.rs Outdated Show resolved Hide resolved
YuriRDev
YuriRDev previously approved these changes Jun 14, 2024
@lemosep lemosep merged commit 657cf64 into main Jun 14, 2024
2 of 3 checks passed
@lemosep lemosep deleted the feat-worker-http branch June 14, 2024 16:42
lemosep added a commit that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants