Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(worker/monitor): add metrics collector #6

Merged
merged 24 commits into from
Apr 11, 2024
Merged

feat(worker/monitor): add metrics collector #6

merged 24 commits into from
Apr 11, 2024

Conversation

YuriRDev
Copy link
Contributor

No description provided.

lffg
lffg reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@lffg lffg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks. :P

ctl/Cargo.toml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
worker/Cargo.toml Outdated Show resolved Hide resolved
worker/src/main.rs Outdated Show resolved Hide resolved
worker/src/metrics.rs Outdated Show resolved Hide resolved
worker/src/metrics.rs Outdated Show resolved Hide resolved
worker/src/metrics.rs Outdated Show resolved Hide resolved
@lffg lffg changed the title feat(worker/monitor): Monitoring hardware information feat(worker/monitor): monitoring hardware information Mar 19, 2024
@lemosep lemosep self-assigned this Mar 20, 2024
@lffg lffg marked this pull request as draft March 21, 2024 01:59
@YuriRDev
Copy link
Contributor Author

YuriRDev commented Apr 5, 2024

Please, remove all println! on the source code.

lffg
lffg reviewed Apr 5, 2024
View reviewed changes
worker/Cargo.toml Outdated Show resolved Hide resolved
lffg
lffg reviewed Apr 5, 2024
View reviewed changes
worker/src/metrics.rs Outdated Show resolved Hide resolved
@lemosep lemosep marked this pull request as ready for review April 5, 2024 19:28
gustavodiasag
gustavodiasag reviewed Apr 5, 2024
View reviewed changes
worker/src/main.rs Outdated Show resolved Hide resolved
worker/src/monitor/metrics_collector.rs Outdated Show resolved Hide resolved
proto/src/common/node.rs Outdated Show resolved Hide resolved
worker/src/monitor/metrics_sender.rs Outdated Show resolved Hide resolved
worker/src/monitor/metrics_collector.rs Outdated Show resolved Hide resolved
worker/src/monitor/metrics_collector.rs Outdated Show resolved Hide resolved
worker/src/monitor/metrics_collector.rs Outdated Show resolved Hide resolved
lffg
lffg reviewed Apr 6, 2024
View reviewed changes
proto/src/common/node.rs Outdated Show resolved Hide resolved
lffg
lffg reviewed Apr 6, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
worker/Cargo.toml Outdated Show resolved Hide resolved
worker/src/main.rs Outdated Show resolved Hide resolved
worker/src/monitor/metrics_collector.rs Outdated Show resolved Hide resolved
lffg
lffg reviewed Apr 6, 2024
View reviewed changes
worker/Cargo.toml Outdated Show resolved Hide resolved
@lffg lffg changed the title feat(worker/monitor): monitoring hardware information feat(worker/monitor): add metrics collector Apr 11, 2024
lemosep
lemosep approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@lemosep lemosep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lffg
lffg approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@lffg lffg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, guys!!

@lemosep lemosep merged commit 3cad55d into main Apr 11, 2024
3 checks passed
@lemosep lemosep deleted the feat(worker/monitor)--added-metrics-collector branch April 11, 2024 23:27
@lffg lffg mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavodiasag gustavodiasag gustavodiasag left review comments

@lemosep lemosep lemosep approved these changes

@lffg lffg lffg approved these changes

Assignees

@YuriRDev YuriRDev

@lemosep lemosep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YuriRDev @lffg @gustavodiasag @lemosep