Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement limiting the number of entries #18

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Implement limiting the number of entries #18

merged 2 commits into from
Sep 17, 2024

Conversation

NelsonVides
Copy link
Collaborator

No description provided.

Base automatically changed from otp27-docs to main September 17, 2024 11:27
@NelsonVides NelsonVides marked this pull request as ready for review September 17, 2024 11:28
@NelsonVides NelsonVides force-pushed the entries_limit branch 2 times, most recently from 2bbbab2 to 5cc397e Compare September 17, 2024 11:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.55%. Comparing base (6b411ed) to head (e03dbc5).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/segmented_cache_helpers.erl 80.64% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   75.28%   75.55%   +0.26%     
==========================================
  Files           4        4              
  Lines         174      180       +6     
==========================================
+ Hits          131      136       +5     
- Misses         43       44       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JanuszJakubiec
JanuszJakubiec approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@JanuszJakubiec JanuszJakubiec merged commit db7d49f into main Sep 17, 2024
3 checks passed
@JanuszJakubiec JanuszJakubiec deleted the entries_limit branch September 17, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszJakubiec JanuszJakubiec JanuszJakubiec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NelsonVides @codecov-commenter @JanuszJakubiec