Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Allowlist in config #745

Merged
merged 10 commits into from
Nov 6, 2023
Merged

Feature Allowlist in config #745

merged 10 commits into from
Nov 6, 2023

Conversation

olekenneth
Copy link
Contributor

@olekenneth olekenneth commented Oct 20, 2023

This will add support for adding config option for allowed packages and multiple scopes. This is extremely helpful for self-hosted version where you don't want someone looping over every package on npm and ddos your server.

This will:

  • add support for multiple scope, not just one
  • allow package names
  • allow something, ban something
  • add tests

@olekenneth olekenneth marked this pull request as draft October 20, 2023 13:45
@olekenneth olekenneth marked this pull request as ready for review October 23, 2023 11:45
@olekenneth
Copy link
Contributor Author

I guess I need approval before the tests will run again

@olekenneth
Copy link
Contributor Author

Need more context to why this feature is wanted/needed?

@olekenneth
Copy link
Contributor Author

@renhiyama @ije Can you help me to get closer to merge?

Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @olekenneth

@ije
Copy link
Member

ije commented Nov 5, 2023

hi @olekenneth can you please check the CI failed? thanks

@olekenneth
Copy link
Contributor Author

Yes. Of course. I'll look at it an hour or so

@ije
Copy link
Member

ije commented Nov 5, 2023

@olekenneth thanks

@ije ije merged commit 4c8e077 into esm-dev:main Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants