Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: write npmrc file if NpmRegistry is set - fixes #737 #751

Merged
merged 1 commit into from
Nov 5, 2023
Merged

fix: write npmrc file if NpmRegistry is set - fixes #737 #751

merged 1 commit into from
Nov 5, 2023

Conversation

edeustace
Copy link
Contributor

@edeustace edeustace commented Oct 27, 2023 •
edited
Loading

fixes #737

@edeustace edeustace changed the title fix: write npmrc file if NpmRegistry is set fixes #737 fix: write npmrc file if NpmRegistry is set - fixes #737 Oct 29, 2023
ije
ije approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ije ije merged commit 8b0300b into esm-dev:main Nov 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ije ije ije approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pnpm should prefer npmRegistry config instead of global npm config
2 participants
@edeustace @ije