ISSUE-61: Remove node_type from drupal configs #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoPino
reviewed
Aug 5, 2022
| @@ -28,14 +28,6 @@ visibility: | |||
| bundles: | |||
| digital_object: digital_object | |||
| digital_object_collection: digital_object_collection | |||
| node_type: | |||
There was a problem hiding this comment.
Wait! The replacement is missing here? I see the node_type gone but not new new Conditional?
There was a problem hiding this comment.
@DiegoPino Unless I'm misunderstanding, I'm assuming that the 'entity_bundle:node' just above it is the correct one since replacing just as the update hook does would make them identical, but I wanted to check in a deployment just to make sure I'm not missing something.
There was a problem hiding this comment.
@aksm No worries, I was mistaken. I saw a bunch of lines removed and did not notice the good/new ones were already present. I will merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #61
Will test in fresh deployment soon.