Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Metadata API Defaults & IIIF Collection Updates for 1.4.0 #271

Merged
merged 14 commits into from
Jun 24, 2024
Merged

New Metadata API Defaults & IIIF Collection Updates for 1.4.0 #271

merged 14 commits into from
Jun 24, 2024

Conversation

alliomeria
Copy link
Contributor

@alliomeria alliomeria commented Jun 24, 2024 •
edited
Loading

For #268:

  • Metadata API default View
  • Metadata APi default Configuration .yml
  • OAI-PMH Item template
  • OAI-PMH Wrapper template for DC
  • updated deploy.sh script (thanks for the reminder Diego!)

For #267

  • updated versions of the IIIF Collection Template

@alliomeria alliomeria requested a review from DiegoPino June 24, 2024 19:20
@alliomeria alliomeria self-assigned this Jun 24, 2024
@alliomeria alliomeria added this to the 1.4.0 milestone Jun 24, 2024
@alliomeria alliomeria changed the title 1.4.0 Metadata API Defaults for 1.4.0 Jun 24, 2024
@alliomeria alliomeria added enhancement New feature or request Drupal YAML files Drupal settings provided by our deployment Site Building Things you do via the UI with a lot of Browser tabs open Twig {% burp %} labels Jun 24, 2024
@DiegoPino
Copy link
Member

@alliomeria this is great.
Could you please also add the new two Twig template JSONs to https://github.com/esmero/archipelago-deployment/blob/1.3.0/scripts/archipelago/deploy.sh and updated one?. That way these get ingested by default on install

Really good work!

@alliomeria
Copy link
Contributor Author

Yes, will do that right now. Thanks for your feedback @DiegoPino !

@alliomeria
Update deploy.sh
0baf452 
To add the two OAI-PMH templates
@alliomeria
Copy link
Contributor Author

Done @DiegoPino --let me know if anything else is needed for this.

@DiegoPino
Copy link
Member

@alliomeria the the update_deployed.sh too please!

This was linked to issues Jun 24, 2024
Updates to the IIIF Collection Manifest Template #267
Closed
Provide example Config/Views for new Metadata API endpoint #268
Closed
@alliomeria
Update update_deployed.sh
4218521 
This one too :)
@alliomeria alliomeria changed the title Metadata API Defaults for 1.4.0 New Metadata API Defaults & IIIF Collection Updates for 1.4.0 Jun 24, 2024
DiegoPino
DiegoPino requested changes Jun 24, 2024
View reviewed changes
Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes sorry. See my comments, please ask for clarification

d8content/metadatadisplay_entity_15.json Outdated Show resolved Hide resolved
d8content/metadatadisplay_entity_18.json Outdated Show resolved Hide resolved
scripts/archipelago/update_deployed.sh Show resolved Hide resolved
@alliomeria alliomeria linked an issue Jun 24, 2024 that may be closed by this pull request
1.4.0 Macro issue: Release tasks pending #270
Open
22 tasks
DiegoPino
DiegoPino approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful @alliomeria . Thanks for addressing my code reviews and fixing all ASAP. Ready for merging now!

@DiegoPino DiegoPino merged commit a3c2674 into esmero:1.4.0 Jun 24, 2024
@DiegoPino
Copy link
Member

Done! Woohoo!

This was referenced Jun 24, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoPino DiegoPino DiegoPino approved these changes

Assignees

@alliomeria alliomeria

Labels
Drupal YAML files Drupal settings provided by our deployment enhancement New feature or request Site Building Things you do via the UI with a lot of Browser tabs open Twig {% burp %}
Projects
None yet
Milestone
1.4.0
2 participants
@alliomeria @DiegoPino