ArchiDeployment/ISSUE-169 --> 1.0.0-RC3 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not liking fontawesome classes being applied to h2 tag in title field We rewrite the field output with an <i> tag
|
@patdunlavey yes since we still have to "somehow" fix the input v/s button issue I feel it is OK. But if you prefer for 1.0.0 I can start that branch too |
|
I have no opinion, so let's leave the target as it is. |
|
OK, can test tomorrow morning (sorry friend just too much code here), should be really quick Thanks |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to Font Awesome 'SVG with JS' not liking fontawesome classes being applied to h2 tag in title field
We rewrite the field output with an
<i>tagSee discussion here
@DiegoPino is 1.0.0-RC3 the correct target for this PR?