Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More json output fixes #1689

Merged
merged 2 commits into from
Apr 29, 2024
Merged

More json output fixes #1689

merged 2 commits into from
Apr 29, 2024

Conversation

bmah888
Copy link
Contributor

@bmah888 bmah888 commented Apr 26, 2024

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies: master

  • Issues fixed (if any): JSON output errors #1688

  • Brief description of code changes (suitable for use as a commit message):

Restructure some code to eliminate duplicat --json output. Fixes #1688.

This is similar to what was done for iperf_errexit() in a previous commit.
…#1688)

Add locking around fprintf() calls in JSONStream_Output(). Probably
not needed at the moment given that this function can only be called
from the main thread, but added for consistency and possible future
usage.
@bmah888 bmah888 self-assigned this Apr 26, 2024
@bmah888 bmah888 linked an issue Apr 26, 2024 that may be closed by this pull request
@bmah888 bmah888 marked this pull request as ready for review April 26, 2024 22:08
@bmah888 bmah888 requested a review from swlars April 26, 2024 22:08
@bmah888 bmah888 added the bug:json Bugs related to JSON output label Apr 29, 2024
Copy link
Contributor

@swlars swlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bmah888 bmah888 merged commit a56a100 into master Apr 29, 2024
6 checks passed
@bmah888 bmah888 deleted the bmah-more-json-output-fixes branch November 19, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:json Bugs related to JSON output
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON output errors
2 participants