Make the 'ble' and 'wifi' options mutually exclusive #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
changed the title
bjoernQ
reviewed
Oct 25, 2024
| } | ||
| } | ||
| } | ||
|
|
||
| if args.option.contains(&String::from("ble")) && args.option.contains(&String::from("wifi")) { |
There was a problem hiding this comment.
That's fine but I was hoping we could detect such a situation more generally by checking the disables field in GeneratorOption
But given this is not a general-purpose library to create project generators it's probably unnecessary to deal with that
There was a problem hiding this comment.
I did consider a more thorough solution, but for the time being this at least solves the linked issue. Can revisit it at a later date.
bjoernQ
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19