Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper logging #30

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Use proper logging #30

merged 1 commit into from
Oct 30, 2024

Conversation

jessebraham
Copy link
Member

Closes #28

SergioGasquez
SergioGasquez approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Cargo.toml Outdated Show resolved Hide resolved
bjoernQ
bjoernQ approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham jessebraham merged commit 4af76e3 into esp-rs:main Oct 30, 2024
8 checks passed
@jessebraham jessebraham deleted the feature/logging branch October 30, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up proper logging
3 participants
@jessebraham @bjoernQ @SergioGasquez