Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor select #47

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Editor select #47

merged 5 commits into from
Nov 18, 2024

Conversation

rmsthebest
Copy link
Contributor

@rmsthebest rmsthebest commented Nov 17, 2024

Mostly fixes #42

I will admit I don't know how to configure neovim, but I've added support for the editor I use anyway.
I could have added editors under the optional section but i felt as if having deeper nested selection was a worse experience. Can move it if you want me to

I snuck in space to select as well as that is quite a common key in these terminal interfaces.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I think we need to update the target on the helix config file and update the changelog file

template/.helix/languages.toml Outdated Show resolved Hide resolved
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I had done this locally and forgot to open a PR myself 😅 But this appears to match what I did almost exactly so LGTM!

@jessebraham jessebraham added this pull request to the merge queue Nov 18, 2024
Merged via the queue into esp-rs:main with commit f95959c Nov 18, 2024
10 checks passed
@rmsthebest rmsthebest deleted the editor-select branch November 18, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested optional config files for editors?
3 participants