Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an argument for template mode #6

Closed
wants to merge 1 commit into from

Conversation

SergioGasquez
Copy link
Member

No description provided.

@bjoernQ
Copy link
Collaborator

bjoernQ commented Oct 8, 2024

Code looks good so far but I'm wondering if it's really more convenient to have multiple template projects (which will duplicate a lot of Cargo.toml, all of config.toml)

Would both templates always support the same options? If not, we would probably duplicate a lot of that

I don't want to be annoying but maybe we should explore the full path of having two (or later more) templates vs. multiple binaries

@SergioGasquez
Copy link
Member Author

I guess it really depends on what we want to support in the near future? If we are going to stay with embassy and blocking for a while, I don't think it's worth splitting them into 2 templates, as it would only reduce a few ifs but duplicate a lot of stuff, and the options if Im not mistaken would be the same as for the blocking template.

But, if we want to add another template, like RTIC, then we should probably split the templates.

@bjoernQ
Copy link
Collaborator

bjoernQ commented Oct 8, 2024

I guess it really depends on what we want to support in the near future? If we are going to stay with embassy and blocking for a while, I don't think it's worth splitting them into 2 templates, as it would only reduce a few ifs but duplicate a lot of stuff, and the options if Im not mistaken would be the same as for the blocking template.

But, if we want to add another template, like RTIC, then we should probably split the templates.

Oh sure - for something totally different like RTIC - yes there another template would make a lot of sense. Haven't thought of RTIC or any other framework t.b.h.

@SergioGasquez SergioGasquez linked an issue Oct 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an argument to choose the template (blocking, async...)
2 participants