[2/3] Timer refactor: TIMG #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
force-pushed
the
dumb-timer/timg
branch
3 times, most recently
from
b1f3c0a
to
fa2cb18
Compare
MabezDev
force-pushed
the
dumb-timer/timg
branch
from
fa2cb18
to
bbec6c0
Compare
|
Skip changelog for the same reasons as part 1 |
Dominaezzz
reviewed
Nov 22, 2024
* Removes _all_ type params on Alarm * Systimer no longer implements peripheral ref, the peripheral ref pattern is instead intended to be used on the higher level timer drivers * Removed `Unit` as a type, in favour of an enum * Alarms are back in the main `SystemTimer` "driver" * Made all `Unit` modification methods unsafe, it's not possible to modify the `Unit`'s safely whilst timers and or the `time::now` API is in use
* Removes _all_ type params on Alarm * Systimer no longer implements peripheral ref, the peripheral ref pattern is instead intended to be used on the higher level timer drivers * Removed `Unit` as a type, in favour of an enum * Alarms are back in the main `SystemTimer` "driver" * Made all `Unit` modification methods unsafe, it's not possible to modify the `Unit`'s safely whilst timers and or the `time::now` API is in use
MabezDev
force-pushed
the
dumb-timer/timg
branch
2 times, most recently
from
e8833cd
to
8ec33b5
Compare
MabezDev
force-pushed
the
dumb-timer/timg
branch
from
8ec33b5
to
a858cfe
Compare
MabezDev
commented
Nov 22, 2024
| - `SystemTimer::set_unit_value` & `SystemTimer::configure_unit` (#2576) | ||
|
|
||
| ### Changed |
There was a problem hiding this comment.
This looks wonky because it's wonky in main: https://github.com/esp-rs/esp-hal/blob/main/esp-hal/CHANGELOG.md
playfulFence
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Part 2 which simplifies the TIMG timers. All sub timers now have the same type erased type:
Timer. I also managed to dedupe and remove the instance trait completely (the instance trait for TIMG still exists), which is a huge code saving.