-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sni support for https #137
base: master
Are you sure you want to change the base?
Conversation
b4d3c05
to
af99eff
Compare
af99eff
to
b551597
Compare
Also, shouldn't we wait until espressif/esp-idf#9833 is merged first? |
No and yes :) #136 adds the https server itself, and this pr extends that with support for sni. This pr is actually based on that pr, and is a superset of that one. Yes, espressif/esp-idf#9833 needs to be merged before this can work, but I wanted this opened so it can be reviewed and used by others looking for sni support. |
b551597
to
0c39a31
Compare
rebased on the merge https server. It fixes a few issues with build on idf master as well. |
0c39a31
to
7dba47e
Compare
@axos88 I have not forgotten about this one, but I hope you don't mind I'll review & merge this post-release of the current |
Thanks @ivmarkov, the upstream changes to esp IDF have been merged, but as I started to use the changes here, i realized a lot of stuff need to be done in a different/better way. I'll need to update this pr before it's worth to spend time reviewing it |
Np, I'll wait. |
8a8adba
to
5ccb542
Compare
Depends on
#136and espressif/esp-idf#9833.Fixes build issues (field renames) on idf master