Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sni support for https #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

axos88
Copy link
Contributor

@axos88 axos88 commented Sep 26, 2022

Depends on #136 and espressif/esp-idf#9833.

Fixes build issues (field renames) on idf master

@axos88 axos88 changed the title Add https support with sni Add sni support for https Sep 26, 2022
@ivmarkov
Copy link
Collaborator

Depends on #136
Isn't this the other way around? As in #137 depending on this one?

@ivmarkov
Copy link
Collaborator

Also, shouldn't we wait until espressif/esp-idf#9833 is merged first?

@axos88
Copy link
Contributor Author

axos88 commented Sep 27, 2022

No and yes :)

#136 adds the https server itself, and this pr extends that with support for sni. This pr is actually based on that pr, and is a superset of that one.

Yes, espressif/esp-idf#9833 needs to be merged before this can work, but I wanted this opened so it can be reviewed and used by others looking for sni support.

@axos88
Copy link
Contributor Author

axos88 commented Oct 2, 2022

rebased on the merge https server. It fixes a few issues with build on idf master as well.

@ivmarkov
Copy link
Collaborator

@axos88 I have not forgotten about this one, but I hope you don't mind I'll review & merge this post-release of the current esp-idf-svc crate. Release is due in a matter of a couple of days actually. We'll issue a subsequent incremental release with your changes then.

@axos88
Copy link
Contributor Author

axos88 commented Nov 20, 2022

Thanks @ivmarkov, the upstream changes to esp IDF have been merged, but as I started to use the changes here, i realized a lot of stuff need to be done in a different/better way. I'll need to update this pr before it's worth to spend time reviewing it

@ivmarkov
Copy link
Collaborator

Thanks @ivmarkov, the upstream changes to esp IDF have been merged, but as I started to use the changes here, i realized a lot of stuff need to be done in a different/better way. I'll need to update this pr before it's worth to spend time reviewing it

Np, I'll wait.

@ivmarkov ivmarkov force-pushed the master branch 3 times, most recently from 8a8adba to 5ccb542 Compare July 5, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants