Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure burst size on async Device, allow 0 as no maximum #308

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Configure burst size on async Device, allow 0 as no maximum #308

merged 2 commits into from
Oct 26, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 25, 2023 •
edited
Loading

I wonder if this affect my case in esp-rs/esp-hal#1605

Oh yes, yes it does: Test complete. Average speed: 129.1kB/s 🎉

bjoernQ
bjoernQ approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit d38763f into esp-rs:main Oct 26, 2023
7 checks passed
@bugadani bugadani deleted the burst branch October 26, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugadani @bjoernQ