Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2: Add BLE support #352

Merged
merged 7 commits into from
Dec 6, 2023
Merged

H2: Add BLE support #352

merged 7 commits into from
Dec 6, 2023

Conversation

JurajSadel
Copy link
Contributor

@JurajSadel JurajSadel commented Nov 22, 2023

Closes #93
Closes #286

Cargo.toml Outdated Show resolved Hide resolved
@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 28, 2023

This should probably wait for #342 to get merged first

@bugadani
Copy link
Contributor

I'm not 100% sure this PR should be blocked on another that is mostly independent of H2 support, but either way I'm not a fan of silently and partially undoing #340 just because some features need to be enabled on a ble example.

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 28, 2023

We should certainly not undo #340
This PR needs "esp-hal-next" and #342 prepares for that as far as I can see

@bugadani
Copy link
Contributor

Fair point. I think now that the first esp-wifi release is available we no longer have to exclusively target released esp-hal versions and these PRs can be pushed forward.

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 28, 2023

Fair point. I think now that the first esp-wifi release is available we no longer have to exclusively target released esp-hal versions and these PRs can be pushed forward.

I agree - with esp-wifi on crates.io we have more freedom on the main branch

@bugadani
Copy link
Contributor

Please add "Closes #93" to the opening message or link that issue. I believe there is no reason for keeping that open if this PR lands.

smoketest.bat Outdated Show resolved Hide resolved
Co-authored-by: Scott Mabin <[email protected]>
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjoernQ bjoernQ merged commit 5e4b215 into esp-rs:main Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esp32-h2 support Bluetooth support for all chips
4 participants