-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H2: Add BLE support #352
H2: Add BLE support #352
Conversation
This should probably wait for #342 to get merged first |
I'm not 100% sure this PR should be blocked on another that is mostly independent of H2 support, but either way I'm not a fan of silently and partially undoing #340 just because some features need to be enabled on a ble example. |
Fair point. I think now that the first esp-wifi release is available we no longer have to exclusively target released esp-hal versions and these PRs can be pushed forward. |
I agree - with esp-wifi on crates.io we have more freedom on the main branch |
Please add "Closes #93" to the opening message or link that issue. I believe there is no reason for keeping that open if this PR lands. |
Co-authored-by: Scott Mabin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #93
Closes #286