Update current support #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if the MSRV is up to date, maybe we could include a MSRV CI check? |
| @@ -62,7 +63,7 @@ Within this crate, `CCOMPARE0` CPU timer is used for timing, ensure that in your | |||
|
|
|||
| When using USB-SERIAL-JTAG (for example by selecting `jtag-serial` in [`esp-println`](https://crates.io/crates/esp-println)) you have to activate the feature `phy-enable-usb`. | |||
|
|
|||
| Don't use this feature if your are _not_ using USB-SERIAL-JTAG as it might reduce WiFi performance. | |||
| Don't use this feature if you are _not__ using USB-SERIAL-JTAG as it might reduce WiFi performance. | |||
There was a problem hiding this comment.
I think this new underscore breaks the markdown rendering.
Suggested change
| Don't use this feature if you are _not__ using USB-SERIAL-JTAG as it might reduce WiFi performance. | |
| Don't use this feature if you are _not_ using USB-SERIAL-JTAG as it might reduce WiFi performance. |
There was a problem hiding this comment.
Ups, good catch, just opened #382 to fix it, for some reason the "Fix" VS Code applied with the Grammarly extension changed it, not sure why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.