Ensure that the WiFi interrupts are only enabled once the ISR is set #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we could enable the interrupts in https://github.com/esp-rs/esp-wifi/blob/a69545dc4c053b9cc9a7398df9250d16834526b5/esp-wifi/src/wifi/os_adapter_esp32c6.rs#L53C33-L53C41 |
I tried that initially, however, set_intr is actually called before set_isr meaning we still run into the same race condition if the WiFi peripheral pends and interrupt through a reset :(. |
MabezDev
force-pushed
the
wifi-interrupt-fixes
branch
2 times, most recently
from
6258d06
to
18e6965
Compare
MabezDev
force-pushed
the
wifi-interrupt-fixes
branch
from
18e6965
to
e9b3090
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #380
Closes #268