Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "no token" warnings. #428

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Feb 2, 2024

They happen often in normal use, such as downloading/uploading a big file
as fast as possible, and they tank performance if logging is enabled.

They happen often in normal use, such as downloading/uploading a big file
as fast as possible, and they tank performance if logging is enabled.
@Dirbaio
Copy link
Contributor Author

Dirbaio commented Feb 2, 2024

This takes a upload speedtest from 80kb/s to 200kb/s :D

@MabezDev MabezDev added the skip-changelog Skip changelog check label Feb 3, 2024
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev merged commit 31ce512 into esp-rs:main Feb 3, 2024
9 of 10 checks passed
@bugadani
Copy link
Contributor

This takes a upload speedtest from 80kb/s to 200kb/s :D

A trick learned from probe-rs? 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants