Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esp-hal etc. #434

Merged
merged 6 commits into from
Mar 12, 2024
Merged

Update esp-hal etc. #434

merged 6 commits into from
Mar 12, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Feb 27, 2024

Prepare to use the unified esp-hal

Keeping it draft for now (until there's a crates.io release)

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is there anything pending?

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Mar 11, 2024

LGTM! Is there anything pending?

There is a problem with S2 I discovered when testing esp-rs/esp-hal#1255

I will double check if it's really just caused by the TRNG implementation in esp-hal.

Would be good to have an esp-wifi release however. Hopefully we can have a patch release to make S2 work again

@noahbliss
Copy link

Can this be merged since the latest esp-hal is currently broken with the latest esp-wifi and esp-rs/esp-hal#1255 has been merged?

@bjoernQ
Copy link
Contributor Author

bjoernQ commented Mar 12, 2024

Can this be merged since the latest esp-hal is currently broken with the latest esp-wifi and esp-rs/esp-hal#1255 has been merged?

There is still an issue with ESP32-S2 which we hopefully get fixed today. Once that is done I will do the release (hopefully today)

@bjoernQ bjoernQ marked this pull request as ready for review March 12, 2024 16:17
@bjoernQ bjoernQ merged commit 022dda6 into main Mar 12, 2024
9 checks passed
@bjoernQ bjoernQ deleted the update-esp-hal branch March 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants