Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version to match the latest release. #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slaff
Copy link

@slaff slaff commented Sep 26, 2018

No description provided.

@marcelstoer
Copy link
Contributor

duplicate of #164 (but Espressif seems to ignore PRs anyhow 😞)

@slaff
Copy link
Author

slaff commented Sep 26, 2018

I create this PR on purpose. Just to emphasize your previous PR(s). And to be honest it puzzles me what can be the reason(s) to not merge such harmless PRs.

@marcelstoer
Copy link
Contributor

The reason I believe is that this repo is a second class citizen to their internal GitLab repo (see #20). So, the way they have currently set it up it's kind of a pain to accept a PR on the non-master repo.

@slaff
Copy link
Author

slaff commented Sep 26, 2018

it's kind of a pain to accept a PR on the non-master repo.

It should not be that difficult. For example if they use internally GIT then it should be no problem to do the following:

cd <internal-repo>
git remote add github https://github.com/espressif/ESP8266_NONOS_SDK.git
git fetch github pull/ID/head:BRANCHNAME

# example: for this PR the exact command should be 
# git fetch github pull/176/head:pr/version-3.3

git checkout BRANCHNAME
# git checkout pr/version-3.3

# Test or do what you want ...
# and finally merge

git checkout master
git merge BRANCH
# git merge pr/version-3.3

Hope that helps.

@wujiangang Will that work for your team?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants