Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for MQTT over WebSockets (CA-119) #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes for MQTT over WebSockets (CA-119) #111

wants to merge 2 commits into from

Conversation

jspngh
Copy link
Contributor

@jspngh jspngh commented Feb 18, 2021

I have split off the WebSockets part from PR #68 and fixed the remarks from @shahpiyushv.
I've tested this with IDF v4.2.

@jspngh
Add support for MQTT over WebSocket.
2704770 
* add missing files in component.mk and port/CMakeLists.txt
* create wsio_esp.c that defines `socketio_get_interface_description`
* give correct response when TLS renegotiation is set in `tlsio_esp_tls_setoption`
@jspngh
Add option to use MQTT_WebSocket_Protocol in iothub_client_sample_mqtt
7a65c0a
@CLAassistant
Copy link

CLAassistant commented Feb 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Fixes for MQTT over WebSockets Fixes for MQTT over WebSockets (CA-119) Feb 18, 2021
@jspngh jspngh mentioned this pull request Feb 18, 2021
Open
@formus14
Copy link

I have tested it out, i could verify it works fine with IDF4.1.1 as well.
However it fails with IDF4.1, showing the following error:
E (24562) esp-tls-mbedtls: read error :-80:

@jspngh
Copy link
Contributor Author

jspngh commented Feb 26, 2021

I believe there was an issue with TLS renegotiation that was fixed and backported to v4.1 and v4.0.
I think it's advisable to use the latest v4.1.x tag or track the release/v4.1 branch if you want to stay on that version.

@MartinTJDK
Copy link
Contributor

When will fix be merged to master? I see same issue regarding TLS renegotiation, where option is not supported.

@jspngh
Copy link
Contributor Author

jspngh commented Jul 5, 2021

Maybe we can tag some of the folks of Espressif who are active in this repository.
@igrr @shahpiyushv @lhespress @projectgus 👋
If anything still needs to be done before this can be merged, please let me know.

@formus14
Copy link

formus14 commented Jul 5, 2021 •
edited
Loading

@MartinTJDK @jspngh Just FYI, The PR is working fine with idf 4.1.1 , 4.2 and 4.2.1
Only idf4.1 had this TLS renegotiation issue ;)

TLS renegotiation was fixed from IDF v4.1.1 on as shown in the release notes
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jspngh @CLAassistant @formus14 @MartinTJDK