Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template: check for adding new component (IEC-13) #157

Closed
tom-borcin opened this issue Mar 2, 2023 · 0 comments · Fixed by #381
Closed

Update PR template: check for adding new component (IEC-13) #157

tom-borcin opened this issue Mar 2, 2023 · 0 comments · Fixed by #381
Labels
enhancement New feature or request

Comments

@tom-borcin
Copy link
Collaborator

After PR #152 is merged, update the PR template, so that when the new component is added, the developer is reminded that they should add the component to this list.

Add pre-commit check that the components here, in .github/workflows/upload_component.yml and in test_apps/CMakeLists.txt are the same.
@tom-borcin tom-borcin mentioned this issue Mar 2, 2023
Merged
@tom-borcin tom-borcin changed the title Update PR template: check for adding new component Update PR template: check for adding new component Apr 21, 2023
@tom-borcin tom-borcin changed the title Update PR template: check for adding new component Update PR template: check for adding new component Apr 24, 2023
@github-actions github-actions bot changed the title Update PR template: check for adding new component Update PR template: check for adding new component (IEC-13) Apr 24, 2023
@igrr igrr added the enhancement New feature or request label Jul 18, 2023
@igrr igrr mentioned this issue Sep 19, 2024
Merged
13 tasks
@igrr igrr linked a pull request Sep 21, 2024 that will close this issue
ci: add component test apps #381
Merged
13 tasks
@igrr igrr closed this as completed in #381 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add component test apps espressif/idf-extra-components
2 participants
@igrr @tom-borcin