Add issue templates #152
Merged
Add issue templates #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Thank you very much @tom-borcin !
I left few comments that might make it even better. I'm happy to hear your ideas ;)
igrr
requested changes
Feb 24, 2023
tom-borcin
requested review from
VojtechBartoska,
igrr and
tore-espressif
and removed request for
VojtechBartoska,
igrr and
tore-espressif
|
@igrr @VojtechBartoska @tore-espressif added your suggestions, please take a look again. Thanks! |
tore-espressif
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
@tom-borcin do you plan more changes or is this ready for merging?
Co-authored-by: Tomas Rezucha <[email protected]>
|
@tore-espressif I accepted all suggestions, so if you have nothing else to change we can merge |
|
Failing tests unrelated to this changes -> merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding issue templates into repository. Please check the templates and let me know if the provided documentation, description, requested data or whole templates make sense.