fix(spi_nand_flash): add dhara to public dependencies (+minor changes) #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 0 tests 0 ✅ 11s ⏱️ Results for commit a16dad8. ♻️ This comment has been updated with latest results. |
igrr
force-pushed
the
bugfix/spi_nand_flash_dhara_dep
branch
from
4a6dd0c to
9845d04
Compare
|
Failing tests are due to the CI workflow refactoring (#381). When the modified component doesn't have any pytest tests, pytest exits with exit code 5 (no tests found). I'll open another PR to fix this. |
RathiSonika
reviewed
Oct 2, 2024
RathiSonika
approved these changes
Oct 2, 2024
Since 892d994, spi_nand_flash.h includes dhara/map.h, so dhara should be a public dependency of spi_nand_flash. Other changes: - move vfs to private requirements (it didn't have to be public) - depend specifically on esp_driver_spi when building for IDF >=5.3
Co-authored-by: RathiSonika <[email protected]>
igrr
force-pushed
the
bugfix/spi_nand_flash_dhara_dep
branch
from
f10a11f to
a16dad8
Compare
|
@RathiSonika Thanks for the review and for spotting the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dhara to public requirements
Since 892d994, spi_nand_flash.h includes dhara/map.h, so dhara should be a public dependency of spi_nand_flash.
Other changes:
esp_driver_spiinstead ofdriverwhen building for IDF >=5.3fix memory leaks in test (free temporary buffers) and raise leak threshold to not detect esp_intr_alloc lazy allocation as a leak
add read/write performance output to the test case
remove unused sbom_dhara.yml file from spi_nand_flash component
version changed from 0.3.1 to 0.4.0 since removing
vfsfrom the public requirements is technically a breaking change