Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gdb panic server from module (RDT-606) #244

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

horw
Copy link
Member

@horw horw commented Dec 5, 2023

Import gdb_panic_server.py from esp_idf_panic_decoder and use it instead of the static $IDF_PATH/tools/gdb_panic_server.py path.
closes #225

@horw horw force-pushed the feat/gdb_panic_server_from_module branch 3 times, most recently from f15212e to dfd7c45 Compare December 6, 2023 02:13
@horw
Copy link
Member Author

horw commented Dec 6, 2023

@hfudev, I have used importlib.util to automatically find the esp-idf-panic-decoder module.

@github-actions github-actions bot changed the title feat: gdb panic server from module feat: gdb panic server from module (RDT-606) Dec 6, 2023
Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Adding it to dependency list could make the code simpler.

pytest-embedded-idf/pytest_embedded_idf/dut.py Outdated Show resolved Hide resolved
pytest-embedded-idf/pytest_embedded_idf/dut.py Outdated Show resolved Hide resolved
@horw horw force-pushed the feat/gdb_panic_server_from_module branch 2 times, most recently from b49a3b0 to 13d7371 Compare December 6, 2023 08:48
Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nitpick on the help message. LGTM! Thank you!

pytest-embedded/pytest_embedded/plugin.py Outdated Show resolved Hide resolved
@horw horw force-pushed the feat/gdb_panic_server_from_module branch from 13d7371 to e1f2f38 Compare December 8, 2023 02:35
@horw horw requested a review from hfudev December 8, 2023 02:36
@hfudev hfudev merged commit 8df0037 into espressif:main Dec 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update with esp-idf-panic-decoder (RDT-525)
2 participants