-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(junit-merger): add flag to preserve Python test cases and "is_unity_case" attribute #324
Merged
hfudev
merged 2 commits into
espressif:main
from
alekseiapa:fix/remove-dut-prefix-from-pytest-xml-attrib-values
Nov 29, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ | |
wokwi_gn, | ||
) | ||
from .log import MessageQueue, PexpectProcess | ||
from .unity import JunitMerger, escape_illegal_xml_chars | ||
from .unity import JunitMerger, UnityTestReportMode, escape_illegal_xml_chars | ||
from .utils import ( | ||
SERVICE_LIB_NAMES, | ||
ClassCliOptions, | ||
|
@@ -111,6 +111,16 @@ def pytest_addoption(parser): | |
help='y/yes/true for True and n/no/false for False. ' | ||
'Set to True to prettify XML junit report. (Default: False)', | ||
) | ||
parser.addoption( | ||
'--unity-test-report-mode', | ||
choices=[UnityTestReportMode.REPLACE.value, UnityTestReportMode.MERGE.value], | ||
default=UnityTestReportMode.REPLACE.value, | ||
help=( | ||
'Specify the behavior for handling Unity test cases in the main JUnit report. ' | ||
"'merge' includes them alongside the parent Python test case. " | ||
"'replace' substitutes the parent Python test case with Unity test cases (default)." | ||
), | ||
) | ||
|
||
# supports parametrization | ||
base_group.addoption('--root-logdir', help='set session-based root log dir. (Default: system temp folder)') | ||
|
@@ -1183,7 +1193,9 @@ def unity_tester(dut: t.Union['IdfDut', t.Tuple['IdfDut']]) -> t.Optional['CaseT | |
|
||
|
||
def pytest_configure(config: Config) -> None: | ||
config.stash[_junit_merger_key] = JunitMerger(config.option.xmlpath) | ||
config.stash[_junit_merger_key] = JunitMerger( | ||
config.option.xmlpath, config.getoption('unity_test_report_mode', default='replace') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missed one |
||
) | ||
config.stash[_junit_report_path_key] = config.option.xmlpath | ||
|
||
config.stash[_pytest_embedded_key] = PytestEmbedded( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.