-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed outdated dependency derivative
#351
base: main
Are you sure you want to change the base?
Conversation
I'll take a look at this either today or tomorrow. Thanks for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks great! And please run the formatter locally
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 63.42% 62.69% -0.73%
==========================================
Files 25 25
Lines 1572 1595 +23
==========================================
+ Hits 997 1000 +3
- Misses 575 595 +20 ☔ View full report in Codecov by Sentry. |
@xNxExOx I've got a lot of the CI fixes running in my test branch. Clippy went and changed some rules on us and then toml upped their MSRV to 1.70. If you're okay waiting for that branch, you can wait it out. Otherwise see if you can tackle the Clippy warnings and update the MSRV (Cargo.toml, README, and main.yml in the workflows). |
Test coverage updates are always appreciated. But I've got 2000+ lines of test code that should cover a majority of the project that is missing it. |
Fixes are in main now. @xNxExOx |
This lgtm, @xNxExOx can you get CI passing and we'll get this merged? |
😕 does these checks pass on the main branch? because they seems totally unrelared to anything I changed. |
Agreed, this is stalled on the deprecated API |
No need to swap to this, but was checking in on alternatives and it looks like the rust language proper just swapped from derivative to https://crates.io/crates/derive-where. |
I see only that the job failed, but no idea why, so I am not looking into it. |
Yup no worries. Working on getting the fix into main. Should happen this weekend or next. |
No description provided.