Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #370, make TimeTriggerConfig pub and add examples for time_trigger #372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #370, make TimeTriggerConfig pub and add examples for time_trigger #372

wants to merge 1 commit into from

Conversation

Dirreke
Copy link
Contributor

@Dirreke Dirreke commented May 3, 2024

Close #370

@Dirreke Dirreke requested review from estk and gadunga as code owners May 3, 2024 06:23
@Dirreke Dirreke mentioned this pull request May 3, 2024
Open
@Dirreke Dirreke force-pushed the pub-timetrigger-config branch 2 times, most recently from 00b9b1c to 02a9f86 Compare May 3, 2024 06:28
@Dirreke Dirreke force-pushed the pub-timetrigger-config branch from 02a9f86 to bbfad0e Compare July 7, 2024 13:48
@Dirreke
Copy link
Contributor Author

Dirreke commented Jul 7, 2024

Fix CI at #377

estk
estk reviewed Jul 9, 2024
View reviewed changes
Copy link
Owner

@estk estk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example!

One question added.

@Dirreke Dirreke force-pushed the pub-timetrigger-config branch from bbfad0e to 9fa2936 Compare July 9, 2024 05:07
@estk
Copy link
Owner

estk commented Jul 9, 2024

This is gtg, just waiting on the #367

@jonygomes06
Copy link

any updates on this come on pls

1 similar comment
@jonygomes06
Copy link

any updates on this come on pls

@bconn98
Copy link
Collaborator

bconn98 commented Aug 1, 2024

Still waiting on the other PR

@jonygomes06
Copy link

i copied it over to my machine and i see that it only triggers for the current process, for example, if i set the time interval to be 1 minute and i kill it and start again after one minute it doesnt roll the log. i would like this lib to be exactly like the NLog in c#
thank you

@Dirreke
Copy link
Contributor Author

Dirreke commented Aug 3, 2024

Thanks. You are right about it. For now, I use static variable to store the start time, so after closing the program, the timer will restart.

My next goal is to read the start time from file, which will solve your issue. However, now we have a series of PR blocked, including some big structural changes. Therefore, I plan to do it after these PR merged(If I still have time).

@jonygomes06
Copy link

Ok no problems, thank you. For now i will use SizeTrigger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bconn98 bconn98 bconn98 approved these changes

@estk estk estk approved these changes

@gadunga gadunga Awaiting requested review from gadunga gadunga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TimeTriggerConfig pub
4 participants
@Dirreke @estk @jonygomes06 @bconn98