euicc: added support for multiple AIDs #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoelacanthusHex
changed the title
This comment was marked as duplicate.
This comment was marked as duplicate.
septs
requested changes
Jan 4, 2025
|
As #157 (comment) said, we can't accept a very certain byte sequence (since that AID isn't a public information) merged in to our code base, so we will happy to accept the env part, would you like to adjust your pr? Thanks. |
This comment was marked as resolved.
This comment was marked as resolved.
- Added env variable "LPAC_CUSTOM_ISD_R_AID" for user defined AIDs - Added documentation for new env var
Root-Core
commented
Jan 4, 2025
septs
approved these changes
Jan 4, 2025
|
Im advocating for a tack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
euicc: added support for multiple AIDs
Closes #157
Closes #175
Not tested for #157, feedback appreciated.