Fix errors

estruyf · Nov 28, 2024 · 98c5b56 · 98c5b56
1 parent f38144b
commit 98c5b56
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/src/panelWebView/components/Fields/TextField.tsx b/src/panelWebView/components/Fields/TextField.tsx
@@ -78,13 +78,10 @@ export const TextField: React.FunctionComponent<ITextFieldProps> = ({
 
   const border = useMemo(() => {
     if (showRequiredState) {
-      updateRequired(false);
       return '1px solid var(--vscode-inputValidation-errorBorder)';
     } else if (!isValid) {
-      updateRequired(true);
       return '1px solid var(--vscode-inputValidation-warningBorder)';
     } else {
-      updateRequired(true);
       return '1px solid var(--vscode-inputValidation-infoBorder)';
     }
   }, [showRequiredState, isValid]);
@@ -162,6 +159,16 @@ export const TextField: React.FunctionComponent<ITextFieldProps> = ({
     );
   }, [settings?.aiEnabled, settings?.copilotEnabled, settings?.seo, name, actions, loading]);
 
+  useEffect(() => {
+    if (showRequiredState) {
+      updateRequired(false);
+    } else if (!isValid) {
+      updateRequired(true);
+    } else {
+      updateRequired(true);
+    }
+  }, [showRequiredState, isValid]);
+
   useEffect(() => {
     if (text !== value && (lastUpdated === null || Date.now() - DEBOUNCE_TIME > lastUpdated)) {
       setText(value || null);

diff --git a/src/panelWebView/components/SeoKeywords.tsx b/src/panelWebView/components/SeoKeywords.tsx
@@ -85,9 +85,7 @@ const SeoKeywords: React.FunctionComponent<ISeoKeywordsProps> = ({
         <VSCodeTableBody>
           {validKeywords.map((keyword, index) => {
             return (
-              <ErrorBoundary key={`${keyword}-${index}`} fallback={<div />}>
-                <SeoKeywordInfo keywords={validKeywords} keyword={keyword} {...data} />
-              </ErrorBoundary>
+              <SeoKeywordInfo key={`${keyword}-${index}`} keywords={validKeywords} keyword={keyword} {...data} />
             );
           })}
         </VSCodeTableBody>