control-plane: delete old log_lines

Upgrades the `delete_old_drafts` function to `delete_old_rows`, because
it's now our one-stop-shop for daily cleanup. This adds deletion of old
`internal.log_lines`, which would otherwise accumulate indefinitely.

supabase/migrations/26_delete_old_drafts.sql → supabase/migrations/26_delete_old_rows.sql

@@ -8,21 +8,34 @@ begin;
 delete from evolutions e where not exists (select d.id from drafts d where d.id = e.draft_id);
 alter table evolutions add foreign key (draft_id) references drafts(id) on delete cascade;
 
-create or replace function internal.delete_old_drafts()
-returns bigint as $$
-  -- These CTE shennanigans brought to you by this rando:
-  -- https://stackoverflow.com/a/47857304
+create or replace function internal.delete_old_rows()
+returns jsonb as $$
+declare
+  n_drafts integer;
+  n_logs integer;
+begin
   with d as (
-    delete from drafts where updated_at < (now() - '30 days'::interval) returning *
+    delete from public.drafts where updated_at < (now() - '30 days'::interval) returning *
   )
-  select count(*) from d;
-$$ language sql security definer;
+  select into n_drafts count(*) as n from d;
+
+  with l as (
+    delete from internal.log_lines where logged_at < (now() - '30 days'::interval) returning *
+  )
+  select into n_logs count(*) as n from l;
+
+  return json_build_object(
+    'drafts', coalesce(n_drafts, 0),
+    'log_lines', coalesce(n_logs)
+  );
+end;
+$$ language plpgsql security definer;
 
 create extension if not exists pg_cron with schema extensions;
 select cron.schedule(
-	'delete-drafts', -- name of the cron job
-	'0 15 * * *', -- Every day at 15:00Z (midmorning EST)
-	$$ select internal.delete_old_drafts() $$
+  'delete-drafts', -- name of the cron job
+  '0 05 * * *', -- Every day at 05:00Z
+  $$ select internal.delete_old_rows() $$
 );
 
 commit;

supabase/tests/draft_deletion.test.sql → supabase/tests/delete_old_rows.test.sql

@@ -1,6 +1,6 @@
 
 
-create function tests.test_draft_deletion()
+create function tests.test_delete_old_rows()
 returns setof text as $$
 declare
   test_user_id uuid = '5ec31342-bfda-43d7-ac62-107e7e2f7f96';
@@ -32,7 +32,18 @@ begin
     (old_draft_id, test_connector_tag_id, 'should delete', 'a/b/c', '{"type": "discoverFailed"}', '{}'),
     (new_draft_id, test_connector_tag_id, 'should retain', 'a/b/d', '{"type": "discoverFailed"}', '{}');
 
-  return query select ok(internal.delete_old_drafts() = 1, 'one draft should have been deleted');
+
+  insert into internal.log_lines (log_line, stream, logged_at, token) values
+    ('should delete line', 'foo', now() - '90 days'::interval, gen_random_uuid()),
+    ('should delete line too', 'foo', now() - '31 days'::interval, gen_random_uuid()),
+    ('should delete line', 'foo', now() - '29 days'::interval, gen_random_uuid()),
+    ('should delete line', 'foo', now() - '5 minutes'::interval, gen_random_uuid());
+
+  --return query select ok(internal.delete_old_drafts() = 1, 'one draft should have been deleted');
+  return query select results_eq(
+    $i$ select internal.delete_old_rows() $i$,
+    $i$ values ('{"drafts": 1, "log_lines": 2}'::jsonb) $i$
+  );
 
   return query select results_eq(
     $i$ select ds.catalog_name::text