Fix/billing report security #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psFried
approved these changes
Sep 1, 2023
| @@ -0,0 +1,166 @@ | |||
| begin; | |||
There was a problem hiding this comment.
I don't think we need to explicitly begin/commit transactions in migrations, since the supabase cli would do that already. Unless I'm missing something?
There was a problem hiding this comment.
Oh, I was just copying the other migrations that seemed to all say
-- Always use a transaction, y'all.
begin;at the top, though I am seeing some that don't have it... do you feel strongly that it should be removed? If not I think it's probably marginally safer to keep it
There was a problem hiding this comment.
I usually apply them with psql, so it's good practice imo. Postgres doesn't mind if they're nested. Also I'm 70% that supabase doesn't wrap in a txn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The only actual change to the billing report is to use
current_setting('role')instead ofsession_roleto check the role of the caller outside ofsecurity definer.This also updates
run_sql_tests.shto return a non-zero exit code on test failure so we can fail the CI run when we break SQL tests in the future.NOTE: not to be merged quite yet, I put an artificial failure in there to make sure the CI run fails as expected.CI failure works as expected!
This change is