-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Implement billing-integrations stripe
CLI
#1180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC we'd discussed this living in another crate that's not part of the workspace, that can have its own Cargo.toml and be invoked via cargo run
. Is there a reason why flowctl
is more appropriate?
I see you're also using the PostgREST API rather than |
I thought you said that you'd be fine with a hidden flowctl command -- having it be in flowctl is nice because the boilerplate for storing/loading control-plane credentials is already handled. |
But sure, if we're getting rid of |
wait, another crate that's not even in the workspace? Do you want me to make a new repo? Or where would it go? |
We do this already for How about it lives in the Flow repo, but is excluded from the workspace. It doesn't need to be built by CI, and we can |
aea8a8e
to
e9d8613
Compare
* For the moment, invoices are created as drafts and have to be approved and sent/paid manually. A draft invoice can be edited, but not sent or paid. * One of the next steps is to display invoice PDFs or links to Stripe's hosted invoice page in the dashboard. Neither of these are available for draft invoices, so only invoices that are manually approved will show the PDF/hosted link. * These invoices are being entered as `collection_method: SendInvoice`, which _requires_ that the associated customer has an email that can receive the invoice. Customers that have already entered payment details will have this email set, but rather than skip all of the customers that haven't gone through that process, I decided to pick the email address of an `admin` user on their tenant. This is only the default, and can be changed once created later.
e9d8613
to
64fb45e
Compare
Moved into separate crate, and updated to use sqlx 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Not knowledgeable about Stripe's API, but for things i do understand this is great. Thanks for re-working it
flowctl raw publish-stripe-invoices
billing-integrations stripe
CLI
collection_method: SendInvoice
, which requires that the associated customer has an email that can receive the invoice. Customers that have already entered payment details will have this email set, but rather than skip all of the customers that haven't gone through that process, I decided to pick the email address of anadmin
user on their tenant. This is only the default, and can be changed once created later.This change is