Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/source-postgres: Set publish_via_partition_root in setup #1199

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

willdonnelly
Copy link
Member

@willdonnelly willdonnelly commented Sep 26, 2023

Description:

Edits all examples of CREATE PUBLICATION queries to be followed by an ALTER PUBLICATION p SET (publish_via_partition_root = true) query.

This is done in a separate ALTER PUBLICATION query because it will fail on versions of PostgreSQL <13 which predate the setting, and if the user blindly executes the commands we want the create portion to succeed anyway.

Also adds some text explaining that the flag is recommended but not required, with a brief explanation of why it's recommended / what it does.


This change is Reviewable

Edits all examples of `CREATE PUBLICATION` queries to be followed
by an `ALTER PUBLICATION p SET (publish_via_partition_root = true)`
query.

This is done in a separate `ALTER PUBLICATION` query because it
will fail on versions of PostgreSQL <13 which predate the setting,
and if the user blindly executes the commands we want the create
portion to succeed anyway.

Also adds some text explaining that the flag is recommended but not
required, with a brief explanation of why it's recommended / what
it does.
@willdonnelly willdonnelly requested a review from a team September 26, 2023 05:27
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-26 16:31 UTC

Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willdonnelly willdonnelly merged commit 41cad8f into master Sep 26, 2023
4 checks passed
@willdonnelly willdonnelly deleted the wgd/postgres-partition-docs-20230925 branch September 26, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants