Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phil/agent jwt secret #1825

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Phil/agent jwt secret #1825

wants to merge 4 commits into from

Conversation

psFried
Copy link
Member

@psFried psFried commented Dec 12, 2024

Description:

Updates the agent to read CONTROL_PLANE_JWT_SECRET from the env instead of querying it from the database. Supabase recently did a rug pull on app.settings.jwt_secret, and agents were relying on the presence of that as part of their startup routine. This updates agent to read the jwt secret from an env variable instead of querying it from the database.

Also updates the internal.access_token_jwt_secret sql function to read the jwt secret from vault instead of relying on app.settings.jwt_secret.

I also hacked in a disablement of the periodic publications, since the fix to make those apply to tasks only hasn't merged yet.

The migration has already been run, and the agents have already been deployed.


This change is Reviewable

@psFried psFried added control-plane change:emergency This change is an emergency labels Dec 12, 2024
@psFried psFried requested a review from jgraettinger December 12, 2024 22:51
@psFried psFried marked this pull request as ready for review December 12, 2024 22:52
@psFried psFried requested a review from jshearer December 13, 2024 17:23
Copy link
Contributor

@jshearer jshearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:emergency This change is an emergency control-plane
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants