Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We do not use reo.dev or linked in ads anymore so removing #1365

Merged
merged 3 commits into from
Nov 22, 2024
Merged

We do not use reo.dev or linked in ads anymore so removing #1365

merged 3 commits into from
Nov 22, 2024

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Nov 18, 2024 •
edited
Loading

Issues

#1370

Changes

1370

  • removing reo.dev from CSP
  • removing linked in from CSP

Tests

Manually tested

  • just hit local

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

If applicable - please include some screenshots of the new UI

@travjenkins travjenkins marked this pull request as ready for review November 18, 2024 16:32
@travjenkins travjenkins requested a review from a team as a code owner November 18, 2024 16:32
@travjenkins travjenkins requested a review from skord November 18, 2024 16:32
@travjenkins travjenkins added the change:planned This is a planned change label Nov 18, 2024
@kiahna-tucker kiahna-tucker removed their request for review November 19, 2024 13:35
@travjenkins travjenkins changed the title We do not use reo.dev anymore so removing We do not use reo.dev or linked in ads anymore so removing Nov 20, 2024
kiahna-tucker
kiahna-tucker approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@kiahna-tucker kiahna-tucker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minimal testing. Ran through workflow happy paths and basic interactions on each page in a local environment.

@travjenkins travjenkins merged commit 783e175 into main Nov 22, 2024
3 checks passed
@travjenkins travjenkins deleted the travjenkins/ops/remove-reo-dev branch November 22, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiahna-tucker kiahna-tucker kiahna-tucker approved these changes

@skord skord Awaiting requested review from skord

Assignees
No one assigned
Labels
change:planned This is a planned change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travjenkins @kiahna-tucker