-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add function for billing per identifier instead of only source #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Please do this little refactor but code cool thanks for improvment to esx_billing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for fix, but please fix little problems.
@Gellipapa Why should |
@Z3rio Hi! The basic logic is to deny because it will always be much more readable to get the actual result than to always write it in IF, look it up. In most cases it's most readable if you exclude everything line by line and at the end you only have the actual result before you always exit the code. This is a common and used method in software development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixes i merged.
This PR aims to primarily add a function to actually bill players based on their identifier, instead of only being able to bill by their source/player id.
Along making these changes, I also felt like incorporating server exports for this would be great, instead of juts having events that can only be triggered from the clientside. Hence the minor logic refactoring in the normal bill function.