Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Guidelines #343

Open
Benzo00 opened this issue Jul 11, 2022 · 0 comments
Open

PR Guidelines #343

Benzo00 opened this issue Jul 11, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@Benzo00
Copy link
Contributor

Benzo00 commented Jul 11, 2022

For those that are trying to contribute to ESX.

https://www.conventionalcommits.org/en/v1.0.0/

Please follow this, as your PRs will not be accepted nor reviewed until your PR titles are following this properly.

1. refactor()
Refactoring is when you change the code, without changing functionality. So minor fixes where the code does the same thing in the end.

2. feat()
feat is for all new code.

3. fix()
fix is just for fixing mistype, or broken code

4. feat!()
all new code, that introduces breaking changes

5. fix!()
fix broken code, but introduce breaking changes

refactor(esx_lscustom/client/main.lua): fixed thread
feat(esx_lscustom/client/main.lua): added new thread for detecting vehicle type
fix(esx_sit/client/list.lua): fixed mistyped variable
refactor(esx_legacy): replaced all instances of table.insert with table[#table+1]
@Benzo00 Benzo00 added the documentation Improvements or additions to documentation label Jul 11, 2022
@Benzo00 Benzo00 pinned this issue Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Development

No branches or pull requests

1 participant