Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locales) Fixing mainly french translations #371

Merged
merged 5 commits into from
Aug 9, 2022
Merged

fix(locales) Fixing mainly french translations #371

merged 5 commits into from
Aug 9, 2022

Conversation

Mathu-lmn
Copy link
Contributor

Fixing main french translations issue ;)

@Mathu-lmn
Copy link
Contributor Author

@Mycroft-Studios Hey, do you have time to review this PR ? I think it's quite interesting ;)

@Benzo00
Copy link
Contributor

Benzo00 commented Aug 7, 2022

take a sec and read this #343 and fix the title :)

@Benzo00 Benzo00 requested a review from jbdevic August 7, 2022 17:26
@Mathu-lmn Mathu-lmn changed the title French translations fix refactor(translations) Fixing mainly french translations Aug 7, 2022
@Mathu-lmn Mathu-lmn changed the title refactor(translations) Fixing mainly french translations fix(locales) Fixing mainly french translations Aug 7, 2022
Copy link
Contributor

@jbdevic jbdevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good.

Looking at the files I saw other errors so it would be necessary to make new changes.
Also, shouldn't we change the currency to €?

[esx_addons]/esx_property/locales/fr.lua Show resolved Hide resolved
[esx_addons]/esx_property/locales/fr.lua Show resolved Hide resolved
@Benzo00 Benzo00 merged commit 453a79f into esx-framework:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants