Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: menu.lua #1495

Merged
merged 3 commits into from
Nov 21, 2024
Merged

update: menu.lua #1495

merged 3 commits into from
Nov 21, 2024

Conversation

Fellow1990
Copy link

Confusion of lowercase and uppercase letters

@Mycroft-Studios Mycroft-Studios changed the base branch from main to dev November 21, 2024 17:42
Kenshiin13
Kenshiin13 previously approved these changes Nov 21, 2024
Copy link
Contributor

@Kenshiin13 Kenshiin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fellow1990 Fellow1990 dismissed Kenshiin13’s stale review November 21, 2024 17:48

The merge-base changed after approval.

@Mycroft-Studios Mycroft-Studios changed the base branch from dev to main November 21, 2024 17:48
@Mycroft-Studios Mycroft-Studios changed the base branch from main to dev November 21, 2024 17:48
@Mycroft-Studios
Copy link
Member

Mycroft-Studios commented Nov 21, 2024

Fixed the branch issues

@Mycroft-Studios Mycroft-Studios merged commit 042ad34 into esx-framework:dev Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Next Update
Development

Successfully merging this pull request may close these issues.

4 participants