Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import new signatures from 4byte.directory #22

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Import new signatures from 4byte.directory #22

merged 1 commit into from
Jun 11, 2018

Conversation

ligi
Copy link
Member

@ligi ligi commented May 22, 2018

No description provided.

@ligi ligi changed the title Import new signatures Import new signatures from 4byte.directory May 22, 2018
@ligi
Copy link
Member Author

ligi commented May 22, 2018

Will not merge for now - seems somebody actively made collisions for ERC-20 here - will need to find a good solution on how to handle this.
CC @pipermerriam @holiman

@holiman
Copy link
Contributor

holiman commented May 23, 2018

Yeah, for now we should remove those obviously mined collisions. Don't know how a long-term fix would look...

@pipermerriam
Copy link

#23

@ligi
Copy link
Member Author

ligi commented Jun 11, 2018

Applied a blacklist for the collisions now

@ligi ligi merged commit f446ce2 into master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants