Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/601 merkle tree crud #723

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Feature/601 merkle tree crud #723

merged 3 commits into from
Aug 11, 2023

Conversation

Kasshern
Copy link
Collaborator

@Kasshern Kasshern commented Aug 10, 2023 •
edited
Loading

Description

Removes the external routes and their commands that would allow an entity to request CRUD operations on merkle trees within the system.

Related Issue

#601

Motivation and Context

Entities should not be able to request CRUD operation on merkle trees from outside the system

How Has This Been Tested

Current test still pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

Therecanbeonlyone1969
Therecanbeonlyone1969 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@Therecanbeonlyone1969 Therecanbeonlyone1969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed

@ognjenkurtic ognjenkurtic merged commit fa5dd7e into main Aug 11, 2023
@ognjenkurtic ognjenkurtic deleted the feature/601-merkle-tree-crud branch August 11, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ognjenkurtic ognjenkurtic ognjenkurtic approved these changes

@Therecanbeonlyone1969 Therecanbeonlyone1969 Therecanbeonlyone1969 approved these changes

@skarred14 skarred14 Awaiting requested review from skarred14 skarred14 is a code owner

@Manik-Jain Manik-Jain Awaiting requested review from Manik-Jain

@skosito skosito Awaiting requested review from skosito skosito is a code owner

@Ybittan Ybittan Awaiting requested review from Ybittan Ybittan is a code owner

@biscuitdey biscuitdey Awaiting requested review from biscuitdey biscuitdey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kasshern @Therecanbeonlyone1969 @ognjenkurtic