Feature/fixed temp logging #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was observed for both chain logs and genesis file logs.
Description
This pull request modifies the
Anvilstruct to ensure that temporary log files are created correctly and that cleanup tasks are registered to remove these files whensupersimstops. This ensures that users can access the log files as expected.Tests
No new tests have been added for this change, as the modifications primarily involve file handling and cleanup logic. However, the existing functionality has been verified to ensure that log files are created and cleaned up correctly.
Additional context
This change improves the usability of
supersimby ensuring that log files are accessible as expected, addressing user frustration with missing log files.Metadata
Fixes #205