Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-698: fix comment #8472

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Update EIP-698: fix comment #8472

merged 1 commit into from
Apr 22, 2024

Conversation

goodactive
Copy link
Contributor

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@goodactive goodactive requested a review from eth-bot as a code owner April 19, 2024 10:39
@github-actions github-actions bot added c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-core labels Apr 19, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 19, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added the e-review Waiting on editor to review label Apr 19, 2024
@eth-bot eth-bot enabled auto-merge (squash) April 22, 2024 14:53
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 1edcf17 into ethereum:master Apr 22, 2024
10 of 11 checks passed
Copy link

The commit 242608e (as a parent of f285405) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-review Waiting on editor to review s-stagnant This EIP is Stagnant t-core w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants