Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add EIP: Box type for EIP-712 messages" #8695

Closed

Conversation

Scamreno
Copy link

Reverts ethereum/EIPs#8594EIPS/eip-7713.md #8008 #8594

eth-bot and others added 30 commits March 3, 2024 08:16
PR 8206 with changes to EIPS/eip-6968.md was created on 
	([email protected])
which is before the cutoff date of 
	([email protected])
i.e. 2 weeks ago
PR 8205 with changes to EIPS/eip-6046.md was created on 
	([email protected])
which is before the cutoff date of 
	([email protected])
i.e. 2 weeks ago
PR 8204 with changes to EIPS/eip-4200.md was created on 
	([email protected])
which is before the cutoff date of 
	([email protected])
i.e. 2 weeks ago
Merged by EIP-Bot.
…y pack precompile address range

Merged by EIP-Bot.
PR 8232 with changes to EIPS/eip-3102.md was created on 
	([email protected])
which is before the cutoff date of 
	([email protected])
i.e. 2 weeks ago
Merged by EIP-Bot.
Fixed a typo regarding EIP numbers:
EIPs 1153, 4788, 4844, 5656, 6780 and 7516(instead of 7526) require changes to Ethereum’s execution layer.
frangio and others added 6 commits June 25, 2024 10:58
* Add EIP: Box types for EIP-712 messages

* add example

* add discussions link

* use gh username

* move link

* add 7683 link

* add syntax highlighting

* Update EIPS/eip-draft_box_types_712.md

Co-authored-by: xinbenlv <[email protected]>

* Update EIPS/eip-draft_box_types_712.md

Co-authored-by: Andrew B Coathup <[email protected]>

* rename

* update title

* reword abstract

* wording

* fix github username

* add whitespace around code block

* remove comments

* review wording

* change 7683 link

* try erc link

* Revert "try erc link"

This reverts commit dd596a0.

* Update eip-7713.md

---------

Co-authored-by: xinbenlv <[email protected]>
Co-authored-by: Andrew B Coathup <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
@Scamreno Scamreno requested a review from eth-bot as a code owner June 27, 2024 16:58
@eth-bot
Copy link
Collaborator

eth-bot commented Jun 27, 2024

File EIPS/eip-7713.md

Requires 1 more reviewers from @frangio
Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added a-review Waiting on author to review e-consensus Waiting on editor consensus labels Jun 27, 2024
@abcoathup
Copy link
Contributor

Reverts ethereum/EIPs#8594EIPS/eip-7713.md #8008 #8594

@Scamreno why are you proposing this? Assume this is in error, recommend closing this PR.

@frangio
Copy link
Contributor

frangio commented Jun 28, 2024

This is spam, there is a lot of spam in this repo sadly. 😕

Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Scamreno Scamreno changed the base branch from master to SamWilsn-patch-1 December 1, 2024 05:09
Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@@ -1,115 +1,7 @@
---
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Scamreno Scamreno changed the base branch from SamWilsn-patch-1 to Pandapip1-patch-1 December 1, 2024 05:19
Copy link

github-actions bot commented Dec 1, 2024

The commit 1228d2e (as a parent of a8fc6be) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 1, 2024
Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@@ -2,6 +2,7 @@ on:
schedule:
# A job that runs every sunday at 00:00
- cron: '0 0 * * 0'
workflow_dispatch:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Author

@Scamreno Scamreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SamWilsn SamWilsn closed this Dec 3, 2024
@ethereum ethereum locked as spam and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a-review Waiting on author to review e-consensus Waiting on editor consensus w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.